Skip to content

Update to Gradle 5.0 #6148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwinch opened this issue Nov 27, 2018 · 4 comments · Fixed by #6197
Closed

Update to Gradle 5.0 #6148

rwinch opened this issue Nov 27, 2018 · 4 comments · Fixed by #6197
Assignees
@rwinch
Labels
in: build An issue in the build type: enhancement A general enhancement
Milestone
5.2.0.M1

Comments

@rwinch
Copy link
Member

rwinch commented Nov 27, 2018

Summary

Gradle 5.0 was released. We should update to it
@rwinch rwinch added in: build An issue in the build type: enhancement A general enhancement labels Nov 27, 2018
@rwinch rwinch added this to the 5.2.0.M1 milestone Nov 27, 2018
@rwinch rwinch added the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Nov 27, 2018
@dbuos
Copy link
Contributor

dbuos commented Nov 29, 2018

I like to work on this issue :)

@dbuos
Copy link
Contributor

dbuos commented Nov 29, 2018

@rwinch I made the change in the gradlew version, but I have some problems with compileJavaAspect task:

Some problems were found with the configuration of task ':spring-security-aspects:compileJavaAspect'.
> No value has been specified for property 'options.extensionDirs'.
> No value has been specified for property 'options.encoding'.
> No value has been specified for property 'options.debugOptions.debugLevel'.
> No value has been specified for property 'options.forkOptions.executable'.

I'll proceed to investigate this further

@dbuos dbuos mentioned this issue Nov 29, 2018
Closed
dbuos added a commit to dbuos/spring-security that referenced this issue Nov 30, 2018
@dbuos
Update to Gradle 5.0
33afbfe 
Change project's gradle version to 5.0, this requires to make some minor
adjustments.

Fixes: spring-projectsgh-6148
@dbuos
Copy link
Contributor

dbuos commented Nov 30, 2018

@rwinch I got the build to work to some extend by filter these null properties as pointed in this issue but it's now failing because of a not existent file reference in spring-security-config.gradle

test {
	inputs.file file("$rootDir/docs/manual/src/docbook/appendix-namespace.xml")
}

After removal of that reference the build is now working.I don't know if I'm missing something related to this file.

@dbuos dbuos mentioned this issue Nov 30, 2018
Merged
rwinch pushed a commit that referenced this issue Nov 30, 2018
@dbuos @rwinch
Update to Gradle 5.0
6bddb38 
Change project's gradle version to 5.0, this requires to make some minor
adjustments.

Fixes: gh-6148
@rwinch rwinch self-assigned this Nov 30, 2018
@rwinch
Copy link
Member Author

rwinch commented Nov 30, 2018

@dbuos Thanks for the fix. This was a legacy file that was being used in the tests that is no longer there as we moved to asciidoctor.

rwinch added a commit that referenced this issue Nov 30, 2018
@rwinch
Update to spring-build-conventions:0.0.23.BUILD-SNAPSHOT
18594ef 
Issue: gh-6148
@artembilan artembilan mentioned this issue Dec 3, 2018
Closed
@rwinch rwinch removed status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: build An issue in the build type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.M1
Development

Successfully merging a pull request may close this issue.

Update to Gradle 5.0 dbuos/spring-security
2 participants
@dbuos @rwinch