Skip to content

Nice to have: hasAnyAuthority() and hasAnyRole() in AuthorizeExchangeSpec #6306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
andysworkshop opened this issue Dec 18, 2018 · 3 comments
Closed

Nice to have: hasAnyAuthority() and hasAnyRole() in AuthorizeExchangeSpec #6306

andysworkshop opened this issue Dec 18, 2018 · 3 comments
Assignees
@rwinch
Milestone
5.2.0.M1

Comments

@andysworkshop
Copy link

Summary

Non-reactive spring security provides hasAnyAuthority() and hasAnyRole() for allowing access if the user has any of the provided authorities/roles. It would be great to see this supported in the reactive API as well.

Actual Behavior

The named methods do not exist on org.springframework.security.config.web.server.ServerHttpSecurity.AuthorizeExchangeSpec

Expected Behavior

The named methods would be provided.

Configuration

Not applicable.

Version

5.1.2

Sample

Not applicable.
@rwinch
Copy link
Member

rwinch commented Dec 18, 2018

@andysworkshop Thanks for the report! Would you be interested in submitting a PR?

@rwinch rwinch added the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Dec 18, 2018
@rmartinus
Copy link
Contributor

I'm happy to give this one a try

@andysworkshop
Copy link
Author

Hi @rmartinus, go for it mate 👍

For reference the method signatures in imperative spring security are in the SecurityExpressionRoot class.

rmartinus added a commit to rmartinus/spring-security that referenced this issue Dec 19, 2018
@rmartinus
Add hasAnyAuthority() and hasAnyRole() in AuthorizeExchangeSpec
c0308ed 
Fixes spring-projectsgh-6306
@rmartinus rmartinus mentioned this issue Dec 19, 2018
Merged
rwinch pushed a commit that referenced this issue Dec 19, 2018
@rmartinus @rwinch
Add hasAnyAuthority() and hasAnyRole() in AuthorizeExchangeSpec
e60ae49 
Fixes gh-6306
@rwinch rwinch self-assigned this Dec 19, 2018
@rwinch rwinch added this to the 5.2.0.M1 milestone Dec 19, 2018
@rwinch rwinch removed status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Jan 29, 2019
@ghost ghost mentioned this issue Feb 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
None yet
Projects
None yet
Milestone
5.2.0.M1
Development

No branches or pull requests
3 participants
@rwinch @andysworkshop @rmartinus