Invalid html in default login page

[bestwmm]

Summary

Invalid html in spring-security/web/src/main/java/org/springframework/security/web/authentication/defaultLoginPageGeneratingFilter.java::generateLoginPageHtml.

Actual Behavior

div class="container" at line 237 is not closed. Closing div required around line 291 before "".

Page does not validate, but Chrome gracioiusly display the page correctly.

Expected Behavior

Pass validation test.

Configuration

n/a

Version

org.spring.framework.boot,l artifactID spring-boot-starter-security version 2.1.0.RELEASE

Sample

[rwinch]

Thanks for the report @bestwmm! Would you be interested in submitting a PR for this?

[bestwmm]

What’s a PR? (Pull Request + submission with fix?) From: Rob Winch [mailto:[email protected]] Sent: Tuesday, January 15, 2019 4:37 AM To: spring-projects/spring-security Cc: bestwmm; Mention Subject: Re: [spring-projects/spring-security] Invalid html in default login page (#6417) Thanks for the report @bestwmm <https://github.com/bestwmm> ! Would you be interested in submitting a PR for this? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6417 (comment)> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AGOuSq5lr-tO_ceRccidZgl9AX5L2nj5ks5vDNxygaJpZM4Z8bRV> . <https://github.com/notifications/beacon/AGOuSsafOFPzynhoQ0M2HsgqX9IqJm2Jks5vDNxygaJpZM4Z8bRV.gif>

[rwinch]

Yes. If you are wanting to learn more, GitHub has more information on what a Pull Request (PR) is. If you are unable to help, that is fine, but your help is always welcome :)

[ankurpathak]

@rwinch I would like to take this one.

[rwinch]

Thanks @ankurpathak! The issue is yours.

@bestwmm If you are wanting to help out with another issue, please use the Help Wanted tag to find issues we feel are good for contributions.

[ankurpathak]

Here is pull request for issue:
#6448

[bestwmm]

Here is pull request for issue:
#6448

Thank you.