Skip to content

Reactive Clear-Site-Data Support #6743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Apr 5, 2019 · 3 comments
Closed

Reactive Clear-Site-Data Support #6743

jzheaux opened this issue Apr 5, 2019 · 3 comments
Assignees
@jzheaux
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Apr 5, 2019

Related to #4187

It would be nice to have the reactive equivalent of Clear Site Data support.
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) New Feature status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Apr 5, 2019
@sayembd
Copy link
Contributor

sayembd commented Apr 6, 2019

@jzheaux can I please take this issue?

@jzheaux
Copy link
Contributor Author

jzheaux commented Apr 8, 2019

For sure! It's yours, @sayembd

@jzheaux jzheaux removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Apr 8, 2019
@jzheaux jzheaux self-assigned this Apr 8, 2019
@sayembd
Copy link
Contributor

sayembd commented Apr 14, 2019

Hi @jzheaux, I have just added a PR: #6777. Feedback/improvement suggestions are highly appreciated!

sayembd added a commit to sayembd/spring-security that referenced this issue Apr 18, 2019
@sayembd
Add Reactive Clear-Site-Data Support
89bacb0 
1. A new implementation of ServerHttpHeadersWriter has been created to
   add Clear-Site-Data header support.
2. A new implementation of ServerLogoutHandler has been created which
   can be configured to write response headers during logout.
3. Added unit tests for both implementations.

Fixes spring-projectsgh-6743
@rwinch rwinch added the type: enhancement A general enhancement label May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rwinch @jzheaux @sayembd