Skip to content

Update to Gradle 5.3.1 #6745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Apr 5, 2019 · 3 comments · Fixed by #6747
Closed

Update to Gradle 5.3.1 #6745

jzheaux opened this issue Apr 5, 2019 · 3 comments · Fixed by #6747
Assignees
@jzheaux
Labels
in: build An issue in the build

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Apr 5, 2019 •
edited
Loading

It would be great to have Spring Security builds running on the latest Gradle.

Basically, this can be done by updating the gradle-wrapper.properties file:

- distributionUrl=https\://services.gradle.org/distributions/gradle-5.0-bin.zip
+ distributionUrl=https\://services.gradle.org/distributions/gradle-5.3.1-bin.zip

And testing the build with ./gradlew clean build integrationTest (locally), with Travis (submitting your PR will do this), and with Jenkins (which the team would help with once your PR is submitted).

To make the last test - against Jenkins - simple, please create a branch from master (off of your spring-security fork) to make the change. Even though this change is small, it will simplify the verification.
@jzheaux jzheaux added in: build An issue in the build status: first-timers-only An issue that can only be worked on by brand new contributors labels Apr 5, 2019
@sayembd
Copy link
Contributor

sayembd commented Apr 6, 2019

Hi, can I take this issue please?

@jzheaux
Copy link
Contributor Author

jzheaux commented Apr 6, 2019

For sure, @sayembd! It's yours.

@jzheaux jzheaux removed the status: first-timers-only An issue that can only be worked on by brand new contributors label Apr 6, 2019
@jzheaux jzheaux self-assigned this Apr 6, 2019
sayembd added a commit to sayembd/spring-security that referenced this issue Apr 6, 2019
@sayembd
Update Gradle version to 5.3.1
c493fad 
Fixes spring-projectsgh-6745
@sayembd sayembd mentioned this issue Apr 6, 2019
Merged
@sayembd
Copy link
Contributor

sayembd commented Apr 6, 2019

Hi @jzheaux, I've just submitted a PR: #6747.

jzheaux pushed a commit that referenced this issue Apr 8, 2019
@sayembd @jzheaux
Update Gradle version to 5.3.1
462b2ec 
Fixes gh-6745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: build An issue in the build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Gradle version to 5.3.1 sayembd/spring-security
2 participants
@jzheaux @sayembd