Skip to content

DefaultServerOAuth2AuthorizationRequestResolver should use fromUri #6952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rwinch opened this issue Jun 4, 2019 · 0 comments
Closed

DefaultServerOAuth2AuthorizationRequestResolver should use fromUri #6952

rwinch opened this issue Jun 4, 2019 · 0 comments
Assignees
@rwinch
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.2.0.M3

Comments

@rwinch
Copy link
Member

rwinch commented Jun 4, 2019 •
edited
Loading

Summary

DefaultServerOAuth2AuthorizationRequestResolver should use UriComponentsBuilder.fromUri rather than HttpComponentsBuilder.fromHttpRequest to be consistent with the rest of Spring Security and to ensure users opt into using request headers.
@rwinch rwinch added type: bug A general bug in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Jun 4, 2019
@rwinch rwinch added this to the 5.2.0.M3 milestone Jun 4, 2019
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-5.1.x labels Jun 4, 2019
Closed
@rwinch rwinch mentioned this issue Jun 4, 2019
Closed
@rwinch rwinch changed the title DefaultServerOAuth2AuthorizationRequestResolver should use fromHttpUrl DefaultServerOAuth2AuthorizationRequestResolver should use fromUri Jun 4, 2019
@rwinch rwinch self-assigned this Jun 4, 2019
@rwinch rwinch closed this as completed in 3c7aa42 Jun 4, 2019
rwinch added a commit that referenced this issue Jun 4, 2019
@rwinch
DefaultServerOAuth2AuthorizationRequestResolver uses fromUri
4f1d7f7 
Fixes gh-6952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.2.0.M3
Development

No branches or pull requests
2 participants
@rwinch @spring-projects-issues