Skip to content

Add OAuth2LoginSpec.authenticationFailureHandler #7051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dsyer opened this issue Jun 28, 2019 · 2 comments · Fixed by #7071
Closed

Add OAuth2LoginSpec.authenticationFailureHandler #7051

dsyer opened this issue Jun 28, 2019 · 2 comments · Fixed by #7071
Assignees
@rwinch
Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Milestone
5.2.0.RC1

Comments

@dsyer
Copy link
Member

dsyer commented Jun 28, 2019

It appears to be possible in MVC but not Webflux.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 28, 2019
@rwinch rwinch added status: ideal-for-contribution An issue that we actively are looking for someone to help us with and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 28, 2019
@rwinch rwinch changed the title Provide DSL for customizing error responses in OAuth2 login with Webflux Add OAuth2LoginSpec.authenticationFailureHandler Jun 28, 2019
@rwinch
Copy link
Member

rwinch commented Jun 28, 2019

Similar to OAuth2LoginSpec.authenticationSuccessHandler we should add OAuth2LoginSpec.authenticationFailureHandler

@rwinch rwinch added the in: config An issue in spring-security-config label Jun 28, 2019
@eddumelendez
Copy link
Contributor

I will take a look into it :)

@rwinch rwinch self-assigned this Jul 3, 2019
@eddumelendez eddumelendez mentioned this issue Jul 4, 2019
Merged
eddumelendez added a commit to eddumelendez/spring-security that referenced this issue Jul 21, 2019
@eddumelendez
Add authenticationFailureHandler method in OAuth2LoginSpec
55d7df2 
Allow to customize the failure handler.

Fixes spring-projectsgh-7051
@rwinch rwinch removed their assignment Jul 29, 2019
rwinch pushed a commit that referenced this issue Aug 5, 2019
@eddumelendez @rwinch
Add authenticationFailureHandler method in OAuth2LoginSpec
2c836a1 
Allow to customize the failure handler.

Fixes gh-7051
@rwinch rwinch self-assigned this Aug 5, 2019
@rwinch rwinch added type: enhancement A general enhancement and removed status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Aug 5, 2019
@rwinch rwinch added this to the 5.2.0.RC1 milestone Aug 5, 2019
kostya05983 pushed a commit to kostya05983/spring-security that referenced this issue Aug 26, 2019
@eddumelendez @kostya05983
Add authenticationFailureHandler method in OAuth2LoginSpec
2d88c5c 
Allow to customize the failure handler.

Fixes spring-projectsgh-7051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.RC1
Development

Successfully merging a pull request may close this issue.

Add authenticationFailureHandler method in OAuth2LoginSpec eddumelendez/spring-security
4 participants
@dsyer @rwinch @eddumelendez @spring-projects-issues