Skip to content

Add RequestMatcher.matcher(HttpServletRequest) #7148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rwinch opened this issue Jul 25, 2019 · 4 comments
Closed

Add RequestMatcher.matcher(HttpServletRequest) #7148

rwinch opened this issue Jul 25, 2019 · 4 comments
Labels
in: web An issue in web modules (web, webmvc) status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement

Comments

@rwinch
Copy link
Member

rwinch commented Jul 25, 2019

Summary

Anyone wanting to take this on can request to take the whole thing on or just one step (but it must be the first step that has not been completed).

Step 1

We should add a default method to RequestMatcher that looks like this:

default MatchResult matcher(HttpServletRequest request) {
	boolean match = matches(request);
    return new MatchResult(match);
}

The MatchResult should look similar to ServerWebExchangeMatcher.MatchResult except it uses servlet request and non-reactive types.

Step 2

Then implementations of RequestVariablesExtractor should be updated to implement the matcher method and RequestVariablesExtractor should be deprecated.

Step 3

Usage of RequestVariablesExtractor or types that are assigned to AntPathRequestMatcher should be replaced with the new method.

@rwinch rwinch added in: web An issue in web modules (web, webmvc) status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement labels Jul 25, 2019
@bobmaertz
Copy link
Contributor

I would like to work on this if its available.

@eddumelendez
Copy link
Contributor

@bou1der I already have the step1. would you like to work with me on this?

eddumelendez added a commit to eddumelendez/spring-security that referenced this issue Jul 26, 2019
@eddumelendez
Copy link
Contributor

@bou1der this is the branch I am using.

@bobmaertz
Copy link
Contributor

@eddumelendez yeah and thanks! I will take a look at the branch later today. If you have a good handle on it, don't let me slow you down. I can help out as much or little as needed.

fhanik pushed a commit to fhanik/spring-security that referenced this issue Aug 1, 2019
fhanik added a commit to fhanik/spring-security that referenced this issue Aug 1, 2019
Step 3 - Usage of RequestVariablesExtractor or types that are assigned
to AntPathRequestMatcher should be replaced with the new method.

[closes spring-projects#7148]
@jzheaux jzheaux closed this as completed in 496579d Aug 5, 2019
jzheaux pushed a commit that referenced this issue Aug 5, 2019
Step 3 - Usage of RequestVariablesExtractor or types that are assigned
to AntPathRequestMatcher should be replaced with the new method.

[closes #7148]
kostya05983 pushed a commit to kostya05983/spring-security that referenced this issue Aug 26, 2019
kostya05983 pushed a commit to kostya05983/spring-security that referenced this issue Aug 26, 2019
Step 3 - Usage of RequestVariablesExtractor or types that are assigned
to AntPathRequestMatcher should be replaced with the new method.

[closes spring-projects#7148]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants