Skip to content

OAuth2LoginConfigurer should discover OAuth2UserService beans #7232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jzheaux opened this issue Aug 7, 2019 · 0 comments
Closed

OAuth2LoginConfigurer should discover OAuth2UserService beans #7232

jzheaux opened this issue Aug 7, 2019 · 0 comments
Assignees
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Aug 7, 2019

This would facilitate constructions like:

void configure(HttpSecurity http) {
    http.
        oauth2Login();
}

@Bean
OAuth2UserService<OidcUserRequest, OidcUser> oidcUserService() {
    return new CustomOidcUserService();
}

@Bean
OAuth2UserService<OAuth2UserRequest, OAuth2UserService> oidcUserService() {
    return new CustomOAuth2UserService();
}
@jzheaux jzheaux added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Aug 7, 2019
@jzheaux jzheaux added this to the 5.2.0.RC1 milestone Aug 7, 2019
@jzheaux jzheaux self-assigned this Aug 7, 2019
@jzheaux jzheaux closed this as completed in a00ad37 Aug 7, 2019
jzheaux added a commit that referenced this issue Aug 7, 2019
Improve way of accessing ApplicationContext to ensure backward
compatibility.

Issue gh-7232
kostya05983 pushed a commit to kostya05983/spring-security that referenced this issue Aug 26, 2019
kostya05983 pushed a commit to kostya05983/spring-security that referenced this issue Aug 26, 2019
Improve way of accessing ApplicationContext to ensure backward
compatibility.

Issue spring-projectsgh-7232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant