Skip to content

Consider renaming OAuth2TokenIntrospectionClient #7245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jzheaux opened this issue Aug 9, 2019 · 0 comments · Fixed by #7246
Closed

Consider renaming OAuth2TokenIntrospectionClient #7245

jzheaux opened this issue Aug 9, 2019 · 0 comments · Fixed by #7246
Assignees
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Aug 9, 2019

The contract for OAuth2TokenIntrospectionClient is String -> Map, taking an opaque token and returning its associated attributes.

The name of the class implies that only implementations that are clients to an OAuth 2.0 Token Introspection endpoint are acceptable.

However, there are use cases where an application has a token and would like to verify and introspect it in a custom way, say via a Redis store.

As such, it would be better if this class were named something more generic like OpaqueTokenIntrospector.

Additionally, the DSL should change to correspond. What was:

http
    .oauth2ResourceServer()
        .opaqueToken()
            .introspectionClient(...)

Should now be:

http
    .oauth2ResourceServer()
        .opaqueToken()
            .introspector(...)
@jzheaux jzheaux added type: enhancement A general enhancement in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Aug 9, 2019
@jzheaux jzheaux added this to the 5.2.0.RC1 milestone Aug 9, 2019
@jzheaux jzheaux self-assigned this Aug 9, 2019
@jzheaux jzheaux changed the title Rename OAuth2TokenIntrospectionClient Consider renaming OAuth2TokenIntrospectionClient Aug 9, 2019
jzheaux added a commit to jzheaux/spring-security that referenced this issue Aug 9, 2019
Renamed to OpaqueTokenIntrospector

Fixes spring-projectsgh-7245
jzheaux added a commit that referenced this issue Aug 12, 2019
Renamed to OpaqueTokenIntrospector

Fixes gh-7245
kostya05983 pushed a commit to kostya05983/spring-security that referenced this issue Aug 26, 2019
Renamed to OpaqueTokenIntrospector

Fixes spring-projectsgh-7245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant