Skip to content

DefaultOAuth2AuthorizedClientManager and DefaultServerOAuth2AuthorizedClientManager Alignment #7350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Sep 3, 2019 · 0 comments
Closed

DefaultOAuth2AuthorizedClientManager and DefaultServerOAuth2AuthorizedClientManager Alignment #7350

jzheaux opened this issue Sep 3, 2019 · 0 comments
Assignees
@jgrandja
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.2.0.RC1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Sep 3, 2019

DefaultOAuth2AuthorizedClientManager maps the username and password fields for the OAuth 2.0 password grant.

However, DefaultServerOAuth2AuthorizedClientManager does not do this.

The rationale given for excluding is:

I don't think it's a good idea to read the request body for each request mapping by default, so I removed that code. The default behaviour for DefaultContextAttributesMapper should read supported query parameters only.

Given the above reasoning, the functionality for DefaultOAuth2AuthorizedClientManager should also be removed.
@jzheaux jzheaux added the in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) label Sep 3, 2019
@jzheaux jzheaux added this to the 5.2.0 milestone Sep 3, 2019
@jzheaux jzheaux mentioned this issue Sep 3, 2019
Closed
@jgrandja jgrandja self-assigned this Sep 4, 2019
@jgrandja jgrandja added the type: enhancement A general enhancement label Sep 4, 2019
@jgrandja jgrandja modified the milestones: 5.2.0, 5.2.0.RC1 Sep 4, 2019
jgrandja added a commit that referenced this issue Sep 4, 2019
@jgrandja
Fix test
409285f 
Issue gh-7350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgrandja jgrandja

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.RC1
Development

No branches or pull requests
2 participants
@jzheaux @jgrandja