Skip to content

SAML Response Skew is using the wrong type #7448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fhanik opened this issue Sep 17, 2019 · 0 comments
Closed

SAML Response Skew is using the wrong type #7448

fhanik opened this issue Sep 17, 2019 · 0 comments
Assignees
@fhanik
Labels
in: saml2 An issue in SAML2 modules type: bug A general bug
Milestone
5.2.0

Comments

@fhanik
Copy link
Contributor

fhanik commented Sep 17, 2019

When passing in response time validation skew to OpenSAML, the type should be long, and not Duration

The correct code would be:

	validationParams.put(
		SAML2AssertionValidationParameters.CLOCK_SKEW,
		this.responseTimeValidationSkew.toMillis()
	);
@fhanik fhanik self-assigned this Sep 18, 2019
@fhanik fhanik added in: saml2 An issue in SAML2 modules type: bug A general bug labels Sep 18, 2019
@fhanik fhanik added this to the 5.2.0 milestone Sep 18, 2019
@fhanik fhanik closed this as completed in 20033ff Sep 24, 2019
fhanik added a commit to fhanik/spring-security that referenced this issue Sep 27, 2019
@fhanik
OpenSAML expects type long representing millis for response time va…
b6a057a 
…lidation skew

Fixes spring-projectsgh-7448

spring-projects#7448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fhanik fhanik

Labels
in: saml2 An issue in SAML2 modules type: bug A general bug
Projects
None yet
Milestone
5.2.0
Development

No branches or pull requests
1 participant
@fhanik