AbstractUserDetailsReactiveAuthenticationManager default Scheduler should be disposed

[robotmrv]

Summary

AbstractUserDetailsReactiveAuthenticationManager creates new parallel Scheduler which creates Threads with daemon=false.

Scheduler scheduler = Schedulers.newParallel("password-encoder");

As states Schedulers.newParallel javadoc

daemon – false if the Scheduler requires an explicit Scheduler.dispose() to exit the VM.

Actual Behavior

default Scheduler is not disposed

1. on AbstractUserDetailsReactiveAuthenticationManager bean destruction
2. or if custom Scheduler was set

Expected Behavior

default Scheduler should be disposed

1. on AbstractUserDetailsReactiveAuthenticationManager bean destruction
2. or if custom Scheduler was set

Version

5.2.0.BUILD-SNAPSHOT

[rwinch]

@robotmrv I went ahead and changed this fix to use a daemon thread instead. We don't need the thread to block shutting down the JVM.

[robotmrv]

@rwinch
I thought about this solution (cb5c58e#r35174748)
Schedulers.newParallel("password-encoder", Schedulers.DEFAULT_POOL_SIZE, true)
but there is another problem
if user wants to refresh application context, default scheduler will not be disposed so unused redundant Threads will be present.
So for this case it should be disposed in anyway

[rwinch]

Thanks. Then perhaps it should be a static member variable w/ the default Scheduler?

[robotmrv]

yes, static default Scheduler will solve that problem