Skip to content

Provide reactive JDBC implementation of ReactiveOAuth2AuthorizedClientService #7890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jgrandja opened this issue Feb 3, 2020 · 10 comments
Closed

Provide reactive JDBC implementation of ReactiveOAuth2AuthorizedClientService #7890

jgrandja opened this issue Feb 3, 2020 · 10 comments
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone
5.5.0-M1

Comments

@jgrandja
Copy link
Contributor

jgrandja commented Feb 3, 2020

This issue addresses the reactive counterpart of #7655.

Related #7889
@jgrandja jgrandja self-assigned this Feb 3, 2020
@jgrandja jgrandja added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement labels Feb 3, 2020
@jgrandja jgrandja added this to the 5.3.0 milestone Feb 3, 2020
@jgrandja jgrandja changed the title Provide reactive JDBC implementation of OAuth2AuthorizedClientService Provide reactive JDBC implementation of ReactiveOAuth2AuthorizedClientService Feb 3, 2020
@jgrandja jgrandja modified the milestones: 5.3.0, 5.3.x Feb 19, 2020
@jgrandja jgrandja removed their assignment May 21, 2020
@jgrandja jgrandja added the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label May 21, 2020
@drgeb
Copy link

drgeb commented Jun 3, 2020

Is there any example of the JDBCReactiveOAuth2AuthorizedClientService that I can start to look at ?

@jgrandja
Copy link
Contributor Author

jgrandja commented Jun 3, 2020 •
edited
Loading

@drgeb This issue is meant to deliver JdbcReactiveOAuth2AuthorizedClientService. The work here hasn't started so there are no examples.

@ghost
Copy link

ghost commented Jun 17, 2020 •
edited by ghost
Loading

Hi @jgrandja if it's ok with you, I can take a look and start the implementation

@jgrandja
Copy link
Contributor Author

@ovidiupopa91 That would be great! The issue is yours.

@jgrandja jgrandja removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Jun 17, 2020
@jgrandja jgrandja assigned ghost Jun 17, 2020
@rwinch
Copy link
Member

rwinch commented Jun 19, 2020

Another thing to keep in mind is that Spring Framework 5.3 is adding support for r2dbc spring-projects/spring-framework#25065 It might be valuable to build off of that and wait until we are on Spring Framework 5.3

@jgrandja
Copy link
Contributor Author

Thanks for the heads up @rwinch. I totally agree that we should wait until Spring Framework 5.3 is out and leverage the provided implementations.

@ovidiupopa91 Let's hold off on this for now. I would rather write less code than more so let's wait until Spring Framework 5.3 is out and then we can proceed.

@jgrandja jgrandja removed this from the 5.3.x milestone Jun 19, 2020
@jgrandja jgrandja unassigned ghost Jun 19, 2020
@rwinch
Copy link
Member

rwinch commented Jun 19, 2020

We could start something in a branch that is based of the current Spring Framework snapshots and then it would be ready when Framework released.

@jgrandja
Copy link
Contributor Author

Makes sense @rwinch.

@ovidiupopa91 Please take a look at the new features added in spring-projects/spring-framework#25065 and leverage for this implementation. Let me know if you have any questions.

@ghost
Copy link

ghost commented Jun 20, 2020

Hi @jgrandja . Great, I'll do that. I will probably open a draft PR to get your feedback as soon as possible.

@ghost
Copy link

ghost commented Jun 22, 2020 •
edited by ghost
Loading

Hi @jgrandja . Can you please reassign me to the issue? (just to avoid what happened when I tried to contribute to the spring-authorization-server project 😃 ) Thank you!

@jgrandja jgrandja assigned ghost Jun 22, 2020
@ghost ghost mentioned this issue Jun 26, 2020
Closed
@jgrandja jgrandja added this to the 5.5.0-M1 milestone Sep 21, 2020
ghost pushed a commit to ovidiupopa07/spring-security that referenced this issue Oct 27, 2020
@ovidiupopa07
Provide a R2dbc implementation of ReactiveOuath2AuthorizedClientService
b2df40f 
Implement R2dbcReactiveOuath2AuthorizedClientService which persists the
Oauth2AuthorizedClient in a sql database

R2dbcReactiveOuath2AuthorizedClientService is using the spring-r2dbc
module to persist/load Oauth2AuthorizedClient to/from a sql database

Add optional depedency to the spring-r2dbc module
Add test compile dependencies to r2dbc-h2 and r2dbc-test

Closes spring-projectsgh-7890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Milestone
5.5.0-M1
Development

Successfully merging a pull request may close this issue.

Provide a R2dbc implementation of ReactiveOuath2AuthorizedClientService ovidiupopa07/spring-security
3 participants
@drgeb @rwinch @jgrandja