RelyingPartyRegistration is built as a link between the relying party's metadata and the asserting party's metadata.
As such, it would be clearer if the method names aligned with what is found in the SPSSODescriptor and IDPSSODescriptor schema definitions.
For example, RelyingPartyRegistration.ProviderDetails contains a method called getWebSsoUrl, but this doesn't readily map to anything in the IDPSSODescriptor. It would be clearer to name it getSingleSignOnServiceLocation since this information is located in <SingleSignOnService Location='${LOCATION}'/>.
Additionally, the same inner class contains a method called getBinding, but this also doesn't map to anything in the descriptor. Instead, it would be clearer to name it getSingleSignOnServiceBinding since this information is located in <SingleSignOnService Binding='${BINDING}'/>.
RelyingPartyRegistrationis built as a link between the relying party's metadata and the asserting party's metadata.As such, it would be clearer if the method names aligned with what is found in the SPSSODescriptor and IDPSSODescriptor schema definitions.
For example,
RelyingPartyRegistration.ProviderDetailscontains a method calledgetWebSsoUrl, but this doesn't readily map to anything in the IDPSSODescriptor. It would be clearer to name itgetSingleSignOnServiceLocationsince this information is located in<SingleSignOnService Location='${LOCATION}'/>.Additionally, the same inner class contains a method called
getBinding, but this also doesn't map to anything in the descriptor. Instead, it would be clearer to name itgetSingleSignOnServiceBindingsince this information is located in<SingleSignOnService Binding='${BINDING}'/>.