Skip to content

Build failures due to Timestamp precision #8782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
eleftherias opened this issue Jul 1, 2020 · 2 comments
Open

Build failures due to Timestamp precision #8782

eleftherias opened this issue Jul 1, 2020 · 2 comments
Labels
in: build An issue in the build type: bug A general bug

Comments

@eleftherias
Copy link
Contributor

Tests relying on HSQLDB 2.5.1 are failing because of https://sourceforge.net/p/hsqldb/bugs/1585/

We will temporarily change our assertions on Timestamp values to be more lenient (to the millisecond).
@eleftherias eleftherias added in: build An issue in the build type: bug A general bug labels Jul 1, 2020
@eleftherias eleftherias self-assigned this Jul 1, 2020
eleftherias added a commit that referenced this issue Jul 1, 2020
@eleftherias
Compare Timestamps up to the millisecond
eb7b276 
Issue gh-8782
eleftherias added a commit that referenced this issue Jul 1, 2020
@eleftherias
Compare Timestamps up to the millisecond
7af5804 
Issue gh-8782
@eleftherias eleftherias added the status: blocked An issue that's blocked on an external project change label Jul 21, 2020
@eleftherias eleftherias removed the status: blocked An issue that's blocked on an external project change label Jun 7, 2021
eleftherias added a commit that referenced this issue Jun 8, 2021
@eleftherias
Revert "Use strict equality for timestamp comparison in JDBC tests"
36805c7 
This reverts commit 09a0670.

This appears to still be an issue in Windows

Issue gh-8782
@eleftherias
Copy link
Contributor Author

It appears this is still an issue on Windows.

@eleftherias eleftherias reopened this Jun 8, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Jun 8, 2021

I wonder if when the issue is fixed with Windows, this commit can also be reverted: a0a9718

akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@eleftherias
Use strict equality for timestamp comparison in JDBC tests
2e4b98a 
This is possible because of the update to HSQLDB 2.6.0
This reverts commit eb7b276.

Closes spring-projectsgh-8782
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@eleftherias
Revert "Use strict equality for timestamp comparison in JDBC tests"
e167893 
This reverts commit 09a0670.

This appears to still be an issue in Windows

Issue spring-projectsgh-8782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: build An issue in the build type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jzheaux @eleftherias