-
Notifications
You must be signed in to change notification settings - Fork 6k
Use constant time comparisons for CSRF tokens #9291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @rwinch , I have a question: will this fix also be merged in the older pipe-lines (I'm interesting in 5.2.x...). |
Hi @rwinch , sorry for annoying... |
Hi @rwinch, will this fix will be merged in older versions like 5.2.x or when can we expect this release |
I have backported the issue (see the linked issues). Each issue has a milestone with the expected release date. |
Thank you @rwinch ! |
While it is not a practical exploit at this point, it is best to be defensive. We should change CSRF token comparison to use a constant time comparison to avoid side channel attacks.
NOTE: This was originally reported via Xhelal Likaj, [email protected]
The text was updated successfully, but these errors were encountered: