Skip to content

Spring Security MessageSource files lack of 'ExceptionTranslationFilter.insufficientAuthentication' #9315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ilxqx opened this issue Dec 26, 2020 · 4 comments · Fixed by #9822, #9868 or #9878
Closed

Spring Security MessageSource files lack of 'ExceptionTranslationFilter.insufficientAuthentication' #9315

ilxqx opened this issue Dec 26, 2020 · 4 comments · Fixed by #9822, #9868 or #9878
Assignees
@jzheaux
Labels
status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement

Comments

@ilxqx
Copy link

ilxqx commented Dec 26, 2020

this.messages.getMessage("ExceptionTranslationFilter.insufficientAuthentication", "Full authentication is required to access this resource")
All of messages_locale.properties files lack of this item.
@ilxqx ilxqx added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Dec 26, 2020
@jzheaux
Copy link
Contributor

jzheaux commented Jan 11, 2021

Good catch, @Venus-WXP! Are you able to contribute any translations in a PR?

@jzheaux jzheaux self-assigned this Jan 11, 2021
@jzheaux jzheaux added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 11, 2021
@spring-projects-issues
Copy link

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.

@spring-projects-issues spring-projects-issues added status: feedback-reminder We've sent a reminder that we need additional information before we can continue status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue status: feedback-reminder We've sent a reminder that we need additional information before we can continue labels Jan 18, 2021
@jzheaux jzheaux added status: ideal-for-contribution An issue that we actively are looking for someone to help us with and removed status: feedback-provided Feedback has been provided labels May 15, 2021
@sjohnr
Copy link
Member

sjohnr commented May 17, 2021

Hi @Venus-WXP,

Looking at the ExceptionTranslationFilter, this message is already able to be localized through MessageSource, but as you noted, we lack several translations. Are you able to add a translation for one or more languages in your own messages_xyz.properties?

For watchers, we would love a contribution on this issue so don't hesitate if you are able to contribute one or more translations for the message: "Full authentication is required to access this resource"

Currently supported locales are:

  • de
  • en
  • ja

Missing locales (that currently have other messages) are:

  • ca
  • cs_CZ
  • es_ES
  • fr
  • it
  • ko_KR
  • lt
  • mn_MN
  • nl
  • pl
  • pt_BR
  • pt_PT
  • ru
  • uk_UA
  • zh_CN
  • zh_TW

@rubensa rubensa mentioned this issue May 27, 2021
Merged
@rubensa
Copy link
Contributor

rubensa commented May 27, 2021

Added pull request for Spanish #9822

@YBCoding YBCoding mentioned this issue Jun 4, 2021
Merged
@sjohnr sjohnr added type: enhancement A general enhancement and removed type: bug A general bug labels Jun 4, 2021
YBCoding added a commit to YBCoding/spring-security that referenced this issue Jun 4, 2021
@YBCoding
Add insufficient authentication message for French
7ab0ab0 
Partially fix spring-projectsgh-9315
pxzxj added a commit to pxzxj/spring-security that referenced this issue Jun 8, 2021
@pxzxj
Add insufficient authentication message for Simplified Chinese and Tr…
6667e7d 
…aditional Chinese

Partially fix spring-projectsgh-9315
@pxzxj pxzxj mentioned this issue Jun 8, 2021
Merged
sjohnr pushed a commit that referenced this issue Jun 14, 2021
@pxzxj @sjohnr
Add insufficient authentication message for Simplified Chinese and Tr…
20577c3 
…aditional Chinese

Partially fix gh-9315
@sjohnr sjohnr reopened this Jun 14, 2021
sjohnr pushed a commit that referenced this issue Jun 15, 2021
@YBCoding @sjohnr
Add insufficient authentication message for French
25fa187 
Partially fix gh-9315
@sjohnr sjohnr reopened this Jun 15, 2021
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@pxzxj
Add insufficient authentication message for Simplified Chinese and Tr…
be9364d 
…aditional Chinese

Partially fix spring-projectsgh-9315
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@YBCoding
Add insufficient authentication message for French
8f9fcbf 
Partially fix spring-projectsgh-9315
jzheaux pushed a commit that referenced this issue Nov 15, 2022
@kylevessPL @jzheaux
Add Polish localization to error messages from ExceptionTranslationFi…
08948f2 
…lter

Issue gh-9315
juhachmann added a commit to juhachmann/spring-security that referenced this issue May 30, 2024
@juhachmann
Adds missing translated messages for PT-BR
1cac396 
Partially fix #spring-projectsgh-9315

Adds Brazilian Portuguese translation missing for following messages in messages_pt_BR.properties;
- ExceptionTranslationFilter.insufficientAuthentication 
- LdapAuthenticationProvider.badLdapConnection
- PersistentTokenBasedRememberMeServices.cookieStolen
@juhachmann juhachmann mentioned this issue May 31, 2024
Merged
jzheaux pushed a commit that referenced this issue May 31, 2024
@juhachmann @jzheaux
Adds missing translated messages for PT-BR
9a71442 
Partially fix #gh-9315

Adds Brazilian Portuguese translation missing for following messages in messages_pt_BR.properties;
- ExceptionTranslationFilter.insufficientAuthentication 
- LdapAuthenticationProvider.badLdapConnection
- PersistentTokenBasedRememberMeServices.cookieStolen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
5 participants
@rubensa @jzheaux @sjohnr @spring-projects-issues @ilxqx