Skip to content

Kotlin DSL extension for HttpSecurity#rememberMe #9319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
unlimitedsola opened this issue Dec 31, 2020 · 6 comments
Closed

Kotlin DSL extension for HttpSecurity#rememberMe #9319

unlimitedsola opened this issue Dec 31, 2020 · 6 comments
Assignees
@eleftherias @IvanPavlov1995
Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Milestone
5.5.0-M3

Comments

@unlimitedsola
Copy link
Contributor

As the title suggests. I found out the Kotlin DSL extension covers most of the configurations but the rememberMe() section. Not sure if there are any reasons that we are missing this?
@unlimitedsola unlimitedsola added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Dec 31, 2020
@eleftherias eleftherias self-assigned this Jan 4, 2021
@eleftherias eleftherias added in: config An issue in spring-security-config and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 4, 2021
@eleftherias
Copy link
Contributor

Thanks for reaching out @unlimitedsola.

Are you interested in submitting a pull request to add the rememberMe() support to the Kotlin DSL?

@IvanPavlov1995
Copy link
Contributor

I'd like to try to submit a pull request for this issue, can I take it?

@eleftherias
Copy link
Contributor

Thanks @IvanPavlov1995! The issue is yours.

@eleftherias
Copy link
Contributor

Hey @IvanPavlov1995, are you still interested in submitting a pull request for this issue?

@IvanPavlov1995
Copy link
Contributor

Hello @eleftherias, yes, but for now I'm too busy so I'm not able to do it during February. If anyone else want to take this issue it would be OK, otherwise I'll return to this in March

@IvanPavlov1995 IvanPavlov1995 mentioned this issue Feb 6, 2021
Merged
IvanPavlov1995 added a commit to IvanPavlov1995/spring-security that referenced this issue Feb 20, 2021
@IvanPavlov1995
Add RememberMeDsl
2ab0b8f 
Issue: spring-projectsgh-9319
eleftherias pushed a commit that referenced this issue Feb 22, 2021
@IvanPavlov1995 @eleftherias
Add RememberMeDsl
857830f 
Issue: gh-9319
@eleftherias
Copy link
Contributor

Closed via 857830f

@eleftherias eleftherias added this to the 5.5.0-M3 milestone Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleftherias eleftherias

@IvanPavlov1995 IvanPavlov1995

Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
None yet
Milestone
5.5.0-M3
Development

No branches or pull requests
3 participants
@unlimitedsola @eleftherias @IvanPavlov1995