Skip to content

Remove javax.annotation Usage from LDAP Tests #9415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Feb 8, 2021 · 0 comments
Closed

Remove javax.annotation Usage from LDAP Tests #9415

jzheaux opened this issue Feb 8, 2021 · 0 comments
Assignees
@jzheaux
Labels
in: ldap An issue in spring-security-ldap type: enhancement A general enhancement
Milestone
5.5.0-M3

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Feb 8, 2021

javax.annotation does not ship with JDK 11. Spring Security uses javax.annotation.PreDestroy in some of its LDAP tests, but such can easily be replaced with implementing DisposableBean.
@jzheaux jzheaux added in: ldap An issue in spring-security-ldap type: enhancement A general enhancement labels Feb 8, 2021
@jzheaux jzheaux self-assigned this Feb 8, 2021
@jzheaux jzheaux mentioned this issue Feb 8, 2021
Closed
7 tasks
jzheaux added a commit to jzheaux/spring-security that referenced this issue Feb 17, 2021
@jzheaux
Remove javax.annotation Usage
b0b5d22 
Closes spring-projectsgh-9415
@jzheaux jzheaux added this to the 5.5.0-M3 milestone Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: ldap An issue in spring-security-ldap type: enhancement A general enhancement
Projects
None yet
Milestone
5.5.0-M3
Development

No branches or pull requests
1 participant
@jzheaux