Skip to content

HttpSecurityConfigurer should have a no-parameter method for authorizeHttpRequests #9498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Mar 12, 2021 · 2 comments
Closed

HttpSecurityConfigurer should have a no-parameter method for authorizeHttpRequests #9498

jzheaux opened this issue Mar 12, 2021 · 2 comments
Assignees
@jzheaux @dratler
Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Milestone
5.6.0-M1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Mar 12, 2021

In #8996, authorizeHttpRequests(Customizer) was introduced.

For consistency with the rest of the DSL, authorizeHttpRequests() should also be added.
@jzheaux jzheaux added type: enhancement A general enhancement status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Mar 12, 2021
@dratler
Copy link
Contributor

dratler commented Apr 2, 2021

Hi @jzheaux ,
is this still open for the grab ?

@jzheaux jzheaux added in: config An issue in spring-security-config and removed status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Apr 5, 2021
@jzheaux jzheaux self-assigned this Apr 5, 2021
@jzheaux jzheaux added this to the 5.5.0-RC1 milestone Apr 5, 2021
@jzheaux
Copy link
Contributor Author

jzheaux commented Apr 5, 2021

Thanks, @dratler! It's yours.

@dratler dratler mentioned this issue Apr 12, 2021
Closed
@jzheaux jzheaux modified the milestones: 5.5.0-RC1, 5.5.0 Apr 12, 2021
@jzheaux jzheaux modified the milestones: 5.5.0, 5.6.0-M1 May 13, 2021
jzheaux added a commit that referenced this issue Jun 28, 2021
@jzheaux
Polish no-parameter authorizeHttpRequests
e91cacf 
- Cleaned up JavaDoc
- Updated implementation to align with no-parameter authorizeRequests
- Updated test names and content for clarity, specifically identified
tests that target no-parameter authorizeHttpRequests with noParameter in
the name
- Switched order of methods to match others in HttpSecurity
- Updated copyright year

Issue gh-9498
@jzheaux jzheaux mentioned this issue Jul 26, 2021
Closed
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
Add no-parameter authorizeHttpRequests method
116f44b 
Closes spring-projectsgh-9498
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@jzheaux
Polish no-parameter authorizeHttpRequests
1a60bd0 
- Cleaned up JavaDoc
- Updated implementation to align with no-parameter authorizeRequests
- Updated test names and content for clarity, specifically identified
tests that target no-parameter authorizeHttpRequests with noParameter in
the name
- Switched order of methods to match others in HttpSecurity
- Updated copyright year

Issue spring-projectsgh-9498
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

@dratler dratler

Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
None yet
Milestone
5.6.0-M1
Development

No branches or pull requests
2 participants
@jzheaux @dratler