Skip to content

Fix package tangle in Resource Server #9576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Apr 8, 2021 · 1 comment
Closed

Fix package tangle in Resource Server #9576

jzheaux opened this issue Apr 8, 2021 · 1 comment
Assignees
@jzheaux
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Milestone
5.5.0-RC1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Apr 8, 2021

The newly added BearerTokenAuthenticationConverter creates a package tangle in the Resource Server support.
@jzheaux jzheaux added type: bug A general bug in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Apr 8, 2021
@jzheaux jzheaux added this to the 5.5.0-RC1 milestone Apr 8, 2021
@jzheaux jzheaux self-assigned this Apr 8, 2021
@jzheaux
Copy link
Contributor Author

jzheaux commented Apr 8, 2021

Since introducing BearerTokenAuthenticationConverter also causes some challenges with #9230, it may be best to expose AuthenticationDetailsSource directly in the filter instead.

@jzheaux jzheaux closed this as completed in 7ded671 Apr 9, 2021
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@jzheaux
Refactor AuthenticationDetailsSource support
d312283 
- BearerTokenAuthenticationFilter exposes this directly, simplifying
configuration and removing a package tangle

Closes spring-projectsgh-9576
@jzheaux jzheaux mentioned this issue Mar 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: bug A general bug
Projects
None yet
Milestone
5.5.0-RC1
Development

No branches or pull requests
1 participant
@jzheaux