SEC-1940 publish event when AccountStatusException #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the submission. Unfortunately, I cannot accept this because there are no tests. You might also read over the recently created Spring Security Contributor Guidelines. Clearly I can write up a fix for this, but I want you to get credit for your work. I'm hoping to get this in the 3.1.2 release (tentatively out next week), so please let me know when you think you can get this done by. If you cannot get it done or I don't hear back, I will go ahead and do it myself. Cheers, |
|
Closing because I have pushed a fix that contains a fix and contains tests in order to ensure this issue gets in the pending release. |
rwinch
pushed a commit
that referenced
this pull request
Oct 30, 2014
Fix directory name for sample pages
This was referenced Feb 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the fix for SEC-546 stopped events being published in the case of an AccountStatusException. The fix for SEC-1940 is to publish the event before rethrowing the exception.