-
Notifications
You must be signed in to change notification settings - Fork 6k
Allow setting custom BodyExtractor to the AbstractWebClientReactiveOAuth2AccessTokenResponseClient #10269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ebClientReactiveOAuth2AccessTokenResponseClient
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bishoybasily!
Please see my inline comments. In addition, will you please add tests that confirm this method works? I think there should be one in each AbstractWebClientReactiveOAuth2AccessTokenResponseClient
implementation's test classes.
Once you are ready, will you please squash your commits and ensure that the commit message ends with "Closes gh-10260" like so:
Add setBodyExtractor
Closes gh-10260
...ecurity/oauth2/client/endpoint/AbstractWebClientReactiveOAuth2AccessTokenResponseClient.java
Show resolved
Hide resolved
Hi @jzheaux, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick turnaround, @bishoybasily!
In addition to my inline comments, will you please double-check that you have a successful run of
./gradlew format check
and make the needed changes? And finally, remember to squash your commits when you are ready.
...urity/oauth2/client/endpoint/WebClientReactiveAuthorizationCodeTokenResponseClientTests.java
Outdated
Show resolved
Hide resolved
Add setBodyExtractor Closes spring-projectsgh-10260
Hi, @jzheaux Thank you so much for your guidance! Done!
|
Thanks, @bishoybasily, this is now merged into |
Thanks, @jzheaux |
A setter added to set the
BodyExtractor
inside theAbstractWebClientReactiveOAuth2AccessTokenResponseClient
Closes gh-10260