Skip to content

Allow setting custom BodyExtractor to the AbstractWebClientReactiveOAuth2AccessTokenResponseClient #10269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

bishoybasily
Copy link
Contributor

@bishoybasily bishoybasily commented Sep 14, 2021

A setter added to set the BodyExtractor inside the AbstractWebClientReactiveOAuth2AccessTokenResponseClient
Closes gh-10260

…ebClientReactiveOAuth2AccessTokenResponseClient
@bishoybasily bishoybasily changed the title #10262 Allow setting custom BodyExtractor to the AbstractWebClientReactiveOAuth2AccessTokenResponseClient Sep 14, 2021
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 14, 2021
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bishoybasily!

Please see my inline comments. In addition, will you please add tests that confirm this method works? I think there should be one in each AbstractWebClientReactiveOAuth2AccessTokenResponseClient implementation's test classes.

Once you are ready, will you please squash your commits and ensure that the commit message ends with "Closes gh-10260" like so:

Add setBodyExtractor

Closes gh-10260

@jzheaux jzheaux self-assigned this Sep 15, 2021
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 15, 2021
@bishoybasily
Copy link
Contributor Author

Hi @jzheaux,
all done, please let me know if something else is missing

Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround, @bishoybasily!

In addition to my inline comments, will you please double-check that you have a successful run of

./gradlew format check

and make the needed changes? And finally, remember to squash your commits when you are ready.

@bishoybasily
Copy link
Contributor Author

bishoybasily commented Sep 16, 2021

Hi, @jzheaux

Thank you so much for your guidance!

Done!

  • Impl. replaced with mock in tests
  • CheckStyle errors fixed

@jzheaux
Copy link
Contributor

jzheaux commented Sep 22, 2021

Thanks, @bishoybasily, this is now merged into main with 8606904

@jzheaux jzheaux closed this Sep 22, 2021
@jzheaux jzheaux added this to the 5.6.0-RC1 milestone Sep 22, 2021
@jzheaux jzheaux added the status: duplicate A duplicate of another issue label Sep 22, 2021
@bishoybasily
Copy link
Contributor Author

Thanks, @jzheaux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAuth2 Token Response Customization
3 participants