-
Notifications
You must be signed in to change notification settings - Fork 6k
Saml2WebSsoAuthenticationFilter adds authentication details #10306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi there! We've been needing authentication details in our product, specifically Notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kehrlann, thank you very much for the PR. I've left some feedback inline.
...ork/security/saml2/provider/service/servlet/filter/Saml2WebSsoAuthenticationFilterTests.java
Outdated
Show resolved
Hide resolved
...ramework/security/saml2/provider/service/servlet/filter/Saml2WebSsoAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Kehrlann.
I've left a couple more suggestions in line. Once you fix them we can merge the PR!
...ramework/security/saml2/provider/service/servlet/filter/Saml2WebSsoAuthenticationFilter.java
Outdated
Show resolved
Hide resolved
...ork/security/saml2/provider/service/servlet/filter/Saml2WebSsoAuthenticationFilterTests.java
Outdated
Show resolved
Hide resolved
Thank you very much @Kehrlann. This is now merged into |
Closes gh-7722.