Add GitHubReleasePlugin with createGitHubRelease task #10483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjohnr
added
status: duplicate
eleftherias
reviewed
Nov 15, 2021
Contributor
eleftherias
left a comment
eleftherias
left a comment
There was a problem hiding this comment.
Looks good @sjohnr! I have left some suggestions inline.
buildSrc/src/main/java/org/springframework/gradle/github/release/GitHubReleasePlugin.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/springframework/gradle/github/release/GitHubReleaseApi.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/springframework/gradle/github/release/CreateGitHubReleaseTask.java
Outdated
Show resolved
Hide resolved
buildSrc/src/main/java/org/springframework/gradle/github/release/RepositoryRef.java
Outdated
Show resolved
Hide resolved
sjohnr
force-pushed
the
gh-10457-github-release-plugin
branch
from
1105967 to
c6c4817
Compare
sjohnr
force-pushed
the
gh-10457-github-release-plugin
branch
from
c6c4817 to
2c952c4
Compare
Contributor
Author
|
@eleftherias, I have updated the PR, including adding additional options I've tested it and it's working well, so we should be able to begin work on automating releases in a pipeline. Let me know if you spot anything else. |
eleftherias
suggested changes
Dec 22, 2021
Contributor
eleftherias
left a comment
eleftherias
left a comment
There was a problem hiding this comment.
I left one comment @sjohnr. In my option you can merge this after that change. I don't think another review is needed.
buildSrc/src/main/java/org/springframework/gradle/github/milestones/GitHubMilestonePlugin.java
Outdated
Show resolved
Hide resolved
sjohnr
force-pushed
the
gh-10457-github-release-plugin
branch
from
2c952c4 to
9deb1f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-10457