-
Notifications
You must be signed in to change notification settings - Fork 6k
Support multiple RequestRejectedHandler beans. #10603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple RequestRejectedHandler beans. #10603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Drezir! In addition to my inline feedback, will you please ensure that the copyright sections at the top of each class are up to date?
...g/src/main/java/org/springframework/security/config/annotation/web/builders/WebSecurity.java
Outdated
Show resolved
Hide resolved
web/src/main/java/org/springframework/security/web/FilterChainProxy.java
Outdated
Show resolved
Hide resolved
web/src/main/java/org/springframework/security/web/firewall/RequestRejectedHandler.java
Outdated
Show resolved
Hide resolved
web/src/main/java/org/springframework/security/web/FilterChainProxy.java
Outdated
Show resolved
Hide resolved
...g/src/main/java/org/springframework/security/config/annotation/web/builders/WebSecurity.java
Show resolved
Hide resolved
d2b442c
to
f9ff7e9
Compare
Copyright sections updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @Drezir, for the updates!
In addition to my inline feedback, will you please add some unit tests to WebSecurityTests
for the new method and to a class called CompositeRequestRejectedHandlerTests
for the new class? Remember to place those tests in their respective commits.
web/src/main/java/org/springframework/security/web/FilterChainProxy.java
Outdated
Show resolved
Hide resolved
web/src/test/java/org/springframework/security/web/FilterChainProxyTests.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/springframework/security/web/firewall/CompositeRequestRejectedHandler.java
Show resolved
Hide resolved
...src/main/java/org/springframework/security/web/firewall/CompositeRequestRejectedHandler.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/springframework/security/web/firewall/CompositeRequestRejectedHandler.java
Outdated
Show resolved
Hide resolved
...g/src/main/java/org/springframework/security/config/annotation/web/builders/WebSecurity.java
Outdated
Show resolved
Hide resolved
...g/src/main/java/org/springframework/security/config/annotation/web/builders/WebSecurity.java
Show resolved
Hide resolved
I have added some tests, thanks to that I have discovered one problem so the tests have proven that they are useful 👍 |
0b839b9
to
d0e8d29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [ ]
I have some issues building project.
May I ask someone to fix checkstyle issues please? Thank you. |
Code changes to the previous PR #8985