Make SAML authentication request uri configurable #11316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Jun 1, 2022
| public Saml2LoginConfigurer<B> authenticationRequestUri(String authenticationRequestUri) { | ||
| Assert.state(authenticationRequestUri.contains("{registrationId}"), | ||
| "authenticationRequestUri must contain {registrationId} path variable"); | ||
| this.authenticationRequestUri = authenticationRequestUri; |
There was a problem hiding this comment.
Please add a check here for OpenSAML 3 usage and break. We shouldn't add this support to OpenSAML 3 since Spring Security no longer supports it.
...g/springframework/security/config/annotation/web/configurers/saml2/Saml2LoginConfigurer.java
Outdated
Show resolved
Hide resolved
...curity/saml2/provider/service/web/authentication/OpenSaml3AuthenticationRequestResolver.java
Outdated
Show resolved
Hide resolved
...curity/saml2/provider/service/web/authentication/OpenSaml4AuthenticationRequestResolver.java
Show resolved
Hide resolved
...g/springframework/security/config/annotation/web/configurers/saml2/Saml2LoginConfigurer.java
Show resolved
Hide resolved
...curity/saml2/provider/service/web/authentication/OpenSaml4AuthenticationRequestResolver.java
Show resolved
Hide resolved
...k/security/saml2/provider/service/web/authentication/Saml2AuthenticationRequestResolver.java
Outdated
Show resolved
Hide resolved
jzheaux
added
type: enhancement
Thanks @jzheaux for your review. I have taken your feedback into account. Don't hesitate if I forget something. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-10840