Skip to content

Add JSON session support for SwitchUserGrantedAuthority #11758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Add JSON session support for SwitchUserGrantedAuthority #11758

wants to merge 7 commits into from

Conversation

markusheiden
Copy link
Contributor

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 27, 2022
@markusheiden
Copy link
Contributor Author

I don't know why unrelated tests fail. Hopefully this is mergeable though.

@sjohnr
Copy link
Member

sjohnr commented Aug 29, 2022

@markusheiden, thanks for the contribution!

I don't know why unrelated tests fail.

If you want to rebase on main, I believe all unrelated tests should pass now.

Hopefully this is mergeable though.

Do you have an issue you're resolving with this PR? I don't see a related issue. If not, can you provide some context around the issue that led to submitting the PR?

@sjohnr sjohnr added status: waiting-for-feedback We need additional information before we can continue in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 29, 2022
@sjohnr sjohnr self-assigned this Aug 29, 2022
@markusheiden
Copy link
Contributor Author

markusheiden commented Aug 31, 2022 •
edited
Loading

Sorry, I thought that it was obvious what this PR wants to achieve.
Here the corresponding issue #11775.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Aug 31, 2022
@sjohnr
Copy link
Member

sjohnr commented Sep 6, 2022

@markusheiden thanks for opening the issue. Note that it's usually best to open an issue before submitting a PR to allow discussion prior to spending time on the PR. I'll add additional comments on the issue.

sjohnr added a commit that referenced this pull request Feb 29, 2024
@sjohnr
Polish gh-11758
bd345fb
@sjohnr
Copy link
Member

sjohnr commented Feb 29, 2024

Thanks @markusheiden, this is now merged for 6.3 as 5c55039 with polish commit bd345fb.

@sjohnr sjohnr closed this Feb 29, 2024
@sjohnr sjohnr removed the status: feedback-provided Feedback has been provided label Feb 29, 2024
@sjohnr sjohnr added this to the 6.3.0-M3 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sjohnr sjohnr

Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Milestone
6.3.0-M3
Development

Successfully merging this pull request may close these issues.
3 participants
@markusheiden @sjohnr @spring-projects-issues