Introducing a SidFactory #15
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…classes that were creating sids now create them via that factory
…classes that were creating sids now create them via that factory
|
Does this go anyway? The pull request is hanging for 2 years already.. There are not that many of changes as for me. |
|
NOTE: Please refer to the referenced JIRA for further discussion. |
|
Closing this PR in favour of #115 |
rwinch
removed
the
status: waiting-for-feedback
This was referenced Feb 5, 2016
bclozel
added a commit
to bclozel/spring-security
that referenced
this pull request
Jan 4, 2017
Add rouge gem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made changes so that nothing differs in the logic of Spring ACL, but if user wants to create custom Sids, he is welcome to introduce and inject his own factory.
Please, consider this patch to be included into Spring ACL sources and I'm really willing to hear the feedback about suggested changes.