-
Notifications
You must be signed in to change notification settings - Fork 6k
Add Kotlin support to PreFilter and PostFilter annotations #15095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @call-me-baki! I've left some feedback inline.
...pringframework/security/access/expression/method/DefaultMethodSecurityExpressionHandler.java
Show resolved
Hide resolved
...pringframework/security/access/expression/method/DefaultMethodSecurityExpressionHandler.java
Show resolved
Hide resolved
Thank you @jzheaux for the feedback! 🙏🏼 I've addressed the requested changes, would you please have a look again? Regarding adding myself to JavaDoc's authors, I'm completely fine if we revert that commit should this change not warrant it. |
Thanks for the updates, @call-me-baki! In preparation for merging, will you please do the following:
|
DefaultMethodSecurityExpressionHandler
Hey @jzheaux! Thanks for your support and guidance. I ran Looking forward to contributing to Spring Security in the future! |
Thanks again, @call-me-baki! This is now merged into |
Closes the following issue:
DefaultMethodSecurityExpressionHandler
#15093Summary
Adds support for Kotlin in
DefaultMethodSecurityExpressionHandler
.It additionally updates the documentation (both
javadoc
andasciidoc
) to reflect the current implementation details and usage.Implementation details
Attempts to mutate the state of either the
Collection
or theMap
:UnsupportedOperationException
is not thrown, returns the instance with its state mutated.UnsupportedOperationException
is thrown, returns a new instance with the filtered state.Tests
The original Java test
DefaultMethodSecurityExpressionHandlerTests
has been left unchanged and acts as a regression test.A new test
DefaultMethodSecurityExpressionHandlerKotlinTests
has been added to assert over the correct behavior when using Kotlin instead of Java.