Skip to content

SEC-1915: Custom ActiveDirectory search filter #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

MateuszRasinski
Copy link
Contributor

Currently the search filter used when retrieving user details is hard coded.

New property in ActiveDirectoryLdapAuthenticationProvider:

  • searchFilter - the LDAP search filter to use when searching for authorities,
    default to search using 'userPrincipalName' (current) OR 'sAMAccountName'

Performed also a refactoring of the ActiveDirectoryLdapAuthenticationProvider.

Currently the search filter used when retrieving user details is hard coded.

New property in ActiveDirectoryLdapAuthenticationProvider:
- searchFilter - the LDAP search filter to use when searching for authorities,
default to search using 'userPrincipalName' (current) OR 'sAMAccountName'

Performed also a refactoring of the ActiveDirectoryLdapAuthenticationProvider.
@MateuszRasinski
Copy link
Contributor Author

I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.

@MateuszRasinski
Copy link
Contributor Author

Similar and partially based on: #18

@donovanmuller
Copy link

Is there any idea when this could be merged?
Facing the same problem and seems there has been no movement on this issue (as well as SEC-2224)

@igler
Copy link

igler commented Feb 5, 2015

@donovanmuller
Copy link

@igler I have done the same until this is fixed. :(

@rwinch
Copy link
Member

rwinch commented Feb 25, 2015

Thanks for the PR! I have merged this into master (see c54346b) with a little bit of polish (see cd352f6). The main point of the polish is that we do not want to change the default search filter to remain passive. I have also pushed the changes into 3.2.x so this will be available in 4.0.0.RC2+ and 3.2.6+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants