Support JWK Selection Strategy in NimbusJwtEncoder #16570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
changed the title
jzheaux
requested changes
Feb 13, 2025
There was a problem hiding this comment.
Thanks, @douxiaofeng99! I've left some feedback inline.
Also, will you please format your commit message with a title and a closes message like so:
Support JWK Selection Strategy
Closes gh-16170
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtEncoder.java
Outdated
Show resolved
Hide resolved
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtEncoder.java
Show resolved
Hide resolved
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtEncoder.java
Outdated
Show resolved
Hide resolved
oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtEncoder.java
Show resolved
Hide resolved
jzheaux
added
type: enhancement
Closes spring-projectsgh-16170 Signed-off-by: douxiaofeng99 <[email protected]>
Make so that it runs only when selection is needed. Require the provided selector be non-null. Add Tests. Issue spring-projectsgh-16170
|
@jzheaux， Thanks you very much! |
jzheaux
approved these changes
Feb 18, 2025
|
Thanks, @douxiaofeng99! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: douxiaofeng99 [email protected]