Skip to content

Fix JdbcUserCredentialRepository Save #16621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2025
Merged

Fix JdbcUserCredentialRepository Save #16621

merged 1 commit into from
Mar 7, 2025

Conversation

franticticktick
Copy link
Contributor

Closes gh-16620

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 19, 2025
@franticticktick franticticktick mentioned this pull request Feb 19, 2025
Closed
jzheaux
jzheaux requested changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @franticticktick, I've left some feedback inline.

@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 24, 2025
@jzheaux jzheaux self-assigned this Feb 24, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Feb 24, 2025

Also, will you please rebase to 6.4.x since that is where the bug first appears?

@jzheaux jzheaux added the type: bug A general bug label Feb 24, 2025
@jzheaux jzheaux added this to the 6.4.x milestone Feb 24, 2025
@franticticktick
Copy link
Contributor Author

franticticktick commented Feb 25, 2025 •
edited
Loading

Hi @jzheaux . Thanks for your feedback. This component was introduced in current version, so it is not in 6.4.x branch.

jzheaux
jzheaux requested changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @franticticktick! I've left a question for you inline.

@jzheaux jzheaux modified the milestones: 6.4.x, 6.5.0-M3, 6.5.x Feb 27, 2025
@franticticktick franticticktick requested a review from jzheaux March 4, 2025 09:13
@jzheaux
Copy link
Contributor

jzheaux commented Mar 7, 2025

Thanks, @franticticktick! Can you squash your commits please? Then I think we're ready to merge.

@jzheaux jzheaux modified the milestones: 6.5.x, 6.5.0-M3 Mar 7, 2025
@franticticktick
Copy link
Contributor Author

@jzheaux sory please, i usually don't miss things like that.

@jzheaux jzheaux merged commit 47630ca into spring-projects:main Mar 7, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Mar 7, 2025

Thanks, @franticticktick! This is now merged into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Projects
None yet
Milestone
6.5.0-M3
Development

Successfully merging this pull request may close these issues.

Bug Report: Duplicate Primary Key Exception in Webauthn4J Authentication
3 participants
@franticticktick @jzheaux @spring-projects-issues