Add toString to IpAddressMatcher #16818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
wtigerhyunsu
force-pushed
the
main
branch
2 times, most recently
from
cd0196c to
437e35d
Compare
jzheaux
added
in: web
jzheaux
requested changes
Mar 26, 2025
There was a problem hiding this comment.
Thanks for the PR, @wtigerhyunsu! I'm glad we were able to together on a solution. I've left some feedback inline, would you be able to make those changes please?
Since the feedback is quite brief, please squash your commits the next time you push so that there continues to be only one commit.
web/src/main/java/org/springframework/security/web/util/matcher/IpAddressMatcher.java
Outdated
Show resolved
Hide resolved
jzheaux
requested changes
Mar 27, 2025
There was a problem hiding this comment.
Thanks for the update, @wtigerhyunsu! I've left another piece of inline feedback.
web/src/test/java/org/springframework/security/web/util/matcher/IpAddressMatcherTests.java
Outdated
Show resolved
Hide resolved
Closes spring-projectsgh-16795 Signed-off-by: wtigerhyunsu <[email protected]>
jzheaux
approved these changes
Mar 27, 2025
jzheaux
changed the title
|
Thanks, @wtigerhyunsu! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-16795
Implemented the toString method based on gh-16795.
In the future, if getHostAddress() or getMaskBits() methods are introduced, the internal logic of toString may be updated to use those methods.
Fixed a formatting issue detected in build #5695 (checkFormatTest failure) and resubmitted the PR.