Skip to content

Polish #17195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Polish #17195

wants to merge 3 commits into from
+23 −21

Conversation

ngocnhan-tran1996
Copy link
Contributor

@ngocnhan-tran1996 ngocnhan-tran1996 commented Jun 2, 2025 •
edited
Loading

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 2, 2025
@rwinch
Copy link
Member

rwinch commented Jun 10, 2025

Thank you for the pull request.

As this pull request is currently created the changelog will say "Polish". This is not a very descriptive entry for a changelog.

Instead, please split this up into multiple pull requests that have titles that are more descriptive.

@rwinch
Copy link
Member

rwinch commented Jun 10, 2025

Closing in favor of multiple pull requests as outlined above.

@rwinch rwinch closed this Jun 10, 2025
@rwinch rwinch self-assigned this Jun 10, 2025
@rwinch rwinch added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwinch rwinch

Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ngocnhan-tran1996 @rwinch @spring-projects-issues