Add password4j implementation of PasswordEncoder #17825
Open
+2,167
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
mehrdadbozorgmehr
force-pushed
the
gh-17706
branch
from
74cf846 to
ae43ab4
Compare
|
Here is my PR. I’d really appreciate any feedback or suggestions for improvements. |
mehrdadbozorgmehr
force-pushed
the
gh-17706
branch
2 times, most recently
from
ca45b53 to
d9494ca
Compare
mehrdadbozorgmehr
changed the title
rwinch
requested changes
Sep 5, 2025
There was a problem hiding this comment.
Thank you for your PR @mehrdadbozorgmehr!
I've provided feedback inline. Once those get addressed, we will want to discuss updating the documentation.
.../src/main/java/org/springframework/security/crypto/password4j/Password4jPasswordEncoder.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/security/crypto/password4j/Password4jPasswordEncoder.java
Outdated
Show resolved
Hide resolved
crypto/src/main/java/org/springframework/security/crypto/factory/PasswordEncoderFactories.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/security/crypto/password4j/Password4jPasswordEncoder.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/security/crypto/password4j/Password4jPasswordEncoder.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/security/crypto/password4j/Password4jPasswordEncoder.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/security/crypto/password4j/Password4jPasswordEncoder.java
Outdated
Show resolved
Hide resolved
...test/java/org/springframework/security/crypto/password4j/Password4jPasswordEncoderTests.java
Show resolved
Hide resolved
mehrdadbozorgmehr
force-pushed
the
gh-17706
branch
3 times, most recently
from
099f552 to
c4d71a5
Compare
mehrdadbozorgmehr
force-pushed
the
gh-17706
branch
5 times, most recently
from
f3b431c to
04f994c
Compare
rwinch
requested changes
Sep 8, 2025
.../src/main/java/org/springframework/security/crypto/password4j/Password4jPasswordEncoder.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/security/crypto/password4j/Password4jPasswordEncoder.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/springframework/security/crypto/password4j/Password4jPasswordEncoder.java
Outdated
Show resolved
Hide resolved
mehrdadbozorgmehr
force-pushed
the
gh-17706
branch
from
7d67c20 to
8bf697a
Compare
rwinch
requested changes
Sep 9, 2025
...test/java/org/springframework/security/crypto/password4j/Password4jPasswordEncoderTests.java
Outdated
Show resolved
Hide resolved
mehrdadbozorgmehr
force-pushed
the
gh-17706
branch
from
8bf697a to
fe8626b
Compare
mehrdadbozorgmehr
force-pushed
the
gh-17706
branch
2 times, most recently
from
441b4cd to
7daccae
Compare
|
Thanks for pointing this out. I’ve updated the design by making Password4jPasswordEncoder abstract and introducing algorithm-specific subclasses for the working implementations. I’ve also implemented a PBKDF2-specific encoder and Balloon hashing in this PR with proper salt handling. @rwinch , please let me know if any additional adjustments are required. |
rwinch
added
in: crypto
rwinch
requested changes
Sep 12, 2025
There was a problem hiding this comment.
Thank you for the changes. Overall they look good. Please:
- Rebase to resolve the conflict
- Add documentation including a whats-new.adoc entry that links to the newly added documentation
- Create two tickets:
- For the password4j implementations supporting upgradeEncoding method
- For the password4j implementations being able to match on the same algorithm when the algorithm contains different parameters. This can be done by using the static
getInstanceFromHash(String)method on the implementation (e.g.BcryptFunction.getInstanceFromHash(String)). Note that not all implementations will be able to support this because not all hashes include the parameters in the resulting hash.
mehrdadbozorgmehr
force-pushed
the
gh-17706
branch
from
7daccae to
a4e6021
Compare
This was referenced Sep 13, 2025
mehrdadbozorgmehr
force-pushed
the
gh-17706
branch
from
69bcb69 to
ea0a347
Compare
…hm selection and enhance documentation Closes spring-projectsgh-17706 Signed-off-by: M.Bozorgmehr <[email protected]> Add Password4jPasswordEncoder for enhanced password hashing support Signed-off-by: M.Bozorgmehr <[email protected]> Signed-off-by: M.Bozorgmehr <[email protected]> Add Password4jPasswordEncoder for enhanced password hashing support Signed-off-by: M.Bozorgmehr <[email protected]> Signed-off-by: Mehrdad <[email protected]> Signed-off-by: M.Bozorgmehr <[email protected]>
…hm selection and enhance documentation Closes spring-projectsgh-17706 Signed-off-by: M.Bozorgmehr <[email protected]> Signed-off-by: Mehrdad <[email protected]> Signed-off-by: M.Bozorgmehr <[email protected]>
…ibrary Closes spring-projectsgh-17706 Signed-off-by: Mehrdad <[email protected]> Signed-off-by: M.Bozorgmehr <[email protected]>
…rd encoders using Password4j library Closes spring-projectsgh-17706 Signed-off-by: Mehrdad <[email protected]> Signed-off-by: M.Bozorgmehr <[email protected]>
…BCrypt, Scrypt, PBKDF2, and Balloon hashing Closes spring-projectsgh-17706 Signed-off-by: M.Bozorgmehr <[email protected]>
mehrdadbozorgmehr
force-pushed
the
gh-17706
branch
from
ea0a347 to
b2d4c52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-17706