Skip to content

Refine SimpleGrantedAuthority #17859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refine SimpleGrantedAuthority #17859

wants to merge 1 commit into from
+17 −7

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Sep 9, 2025 •
edited
Loading

  1. Deprecate field role in favor of authority since role is specific authority.
  2. Add Javadoc to state that role should be prefixed.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 9, 2025
@rwinch
Copy link
Member

rwinch commented Sep 9, 2025

Can you elaborate on why you want to make this change? Given that role is internal, I don't see a lot of value making a breaking change.

@rwinch rwinch added status: waiting-for-feedback We need additional information before we can continue and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 9, 2025
@rwinch rwinch self-assigned this Sep 9, 2025
@rwinch rwinch added in: core An issue in spring-security-core type: breaks-passivity A change that breaks passivity with the previous release labels Sep 9, 2025
@quaff
Copy link
Contributor Author

quaff commented Sep 10, 2025

Can you elaborate on why you want to make this change? Given that role is internal, I don't see a lot of value making a breaking change.

I'm confused by the name while reading the source, I force pushed a commit, it's not a breaking change now.
I'm OK to revert the code changes, but I think it's valuable to improve Javadoc to elaborate why the name must be role not authority, and if the authority is a role it should be prefixed.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Sep 10, 2025
@quaff
Refine SimpleGrantedAuthority
1c5bf07 
1. Deprecate field `role` in favor of `authority` since role is specific authority.
2. Add Javadoc to state that role should be prefixed.

Signed-off-by: Yanming Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rwinch rwinch

Labels
in: core An issue in spring-security-core status: feedback-provided Feedback has been provided type: breaks-passivity A change that breaks passivity with the previous release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quaff @rwinch @spring-projects-issues