Fix Javadoc on methods of AbstractAuthenticationProcessingFilter #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both overloads of AbstractAuthenticationProcessingFilter.successfulAuthentication() claimed to invoke SessionAuthenticationStrategy, which is not true, as the invokation happens earlier in doFilter(). The Javadoc on these methods are updated to reflect the actual code.
|
Thank you for your contribution. Can you please resubmit using the guidelines from the contributors guidelines? Specifically:
|
|
I skipped the JIRA ticket creation, because the guideline mentions that it's not necessary for trivial changes. :) |
|
You are correct the guidelines do state that trivial changes do not require a JIRA. I have updated the guidelines to reflect that if it is a non-user facing issue that it does not require a JIRA. In general, if a user may encounter the issue it is best to have a JIRA for it so that it appears in the change log. Thanks for pointing this out and for the javadoc fix. |
This was referenced Feb 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Javadoc on some methods to reflect the actual code.
I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.