Replace improper JsonNode.toString() in Jackson support #4253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way, I'm really interested in having the fix integrated in 4.2, I can rebase my branch on |
rwinch
force-pushed
the
master
branch
2 times, most recently
from
0e114c6 to
fd244eb
Compare
Not only is it more efficient without converting to an intermediate String, using JsonNode.toString() may not even produce valid JSON according to its Javadoc (ObjectMapper.writeValueAsString() should be used).
fpavageau
force-pushed
the
jackson_session_support
branch
from
1c63948 to
2fe64ac
Compare
When the principal of the Authentication is an object, it is not necessarily an User: it could be another implementation of UserDetails, or even a completely unrelated type. Since the type of the object is serialized as a property and used by the deserialization anyway, there's no point in enforcing a stricter type.
fpavageau
force-pushed
the
jackson_session_support
branch
from
2fe64ac to
10878d1
Compare
|
The branch has been rebased on master and adapted to the changes in #4370. |
|
Thanks for the PR @fpavageau! This is merged into master. If you would like to submit a PR for 4.2.x, I'd be glad to merge it |
rwinch
changed the title
| @@ -50,10 +50,10 @@ public Set deserialize(JsonParser jp, DeserializationContext ctxt) throws IOExce | |||
| Iterator<JsonNode> nodeIterator = arrayNode.iterator(); | |||
| while (nodeIterator.hasNext()) { | |||
| JsonNode elementNode = nodeIterator.next(); | |||
| resultSet.add(mapper.readValue(elementNode.toString(), Object.class)); | |||
| resultSet.add(mapper.readValue(elementNode.traverse(mapper), Object.class)); | |||
There was a problem hiding this comment.
... just by chance noticed this. May have been changed since then, but method mapper.treeToValue() would perhaps be best method to use here. It does translate to very similar call so it's not a big deal either way, and code above works fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull-request addresses 2 issues:
JsonNode.toString()to serialize a sub-tree before deserializing it using anObjectMapper.User.This fixes #4252.