Adding nonce to Authentication Request #4442 #4629
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwinch
added
the
in: oauth2
jgrandja
requested changes
Oct 16, 2017
| @@ -131,6 +132,8 @@ private void sendRedirectForAuthorization(HttpServletRequest request, HttpServle | |||
| Map<String,Object> additionalParameters = new HashMap<>(); | |||
| additionalParameters.put(OAuth2Parameter.REGISTRATION_ID, clientRegistration.getRegistrationId()); | |||
|
|
|||
| String nonce = request.getParameter(OAuth2Parameter.NONCE); | |||
There was a problem hiding this comment.
The nonce does not come from the HttpServletRequest. It must be produced by this filter and added as a request parameter as part of the Authentication Request.
It then needs to get correlated/validated in the ID Token
See comment for implementation notes
There was a problem hiding this comment.
@jgrandja I will work on these and commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding nonce to Authentication Request #4442