Add FirstOfMultifactorAuthenticationToken #5196
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ynojima Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@ynojima Thank you for signing the Contributor License Agreement! |
To indicate the state of principal which passed first step of multi step (factor) authehntication
ynojima
force-pushed
the
custom-for-webauthn-support
branch
from
6cc387d to
c1012e9
Compare
|
Thank you for the PR! I'm going to close this ticket as I do not like to merge features in until we have concrete user facing code that is ready to merge. We will wait until we have #5238 ready. Also of important notice is we cannot make breaking changes to our APIs. So something like this cannot be done https://github.com/spring-projects/spring-security/pull/5196/files#diff-ed434fe5d44eed9505c5ee9c205225e5R61 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Please read the issue first : #2603 (comment))
To support FIDO-U2F or Web Authentication with FIDO-U2F device, an authentication token for indicating the user passed the first step of multi step(factor) authentication is required.
FirstOfMultiFactorAuthenticationTokenis meant to support the scenario. Also, by makingAuthenticationTrustResolverImplreturn false for the token, existing spring security application can introduce Multi Factor AuthenticationProvider like https://github.com/ynojima/spring-security-webauthn with minimum modification.(maybe
FirstOfMultiFactorAuthenticationTokenis not proper naming, but I couldn't find another name.)