Skip to content

AccountStatusUserDetailsChecker implements MessageSourceAware #6151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2019

Conversation

weebl2000
Copy link

This should fix #3980

@pivotal-issuemaster
Copy link

@weebl2000 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@weebl2000 Thank you for signing the Contributor License Agreement!

Copy link
Member

@rwinch rwinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I provided feedback inline

@weebl2000
Copy link
Author

Should be fixed

@rwinch
Copy link
Member

rwinch commented Dec 5, 2018

Thanks @weebl2000!

Can you please update the commit message to align with the Spring Security conventions? It is missing Fixes: gh-3980 so something like...

Make AccountStatusUserDetailsChecker implement MessageSourceAware

Fixes: gh-3980

@weebl2000
Copy link
Author

weebl2000 commented Dec 7, 2018

Amended commit message to include "Fixes: gh-3980"

@rwinch rwinch changed the title Make AccountStatusUserDetailsChecker implement MessageSourceAware AccountStatusUserDetailsChecker implements MessageSourceAware Dec 7, 2018
@rwinch rwinch self-assigned this Dec 7, 2018
@rwinch rwinch added in: core An issue in spring-security-core type: enhancement A general enhancement labels Dec 7, 2018
@rwinch rwinch added this to the 5.2.0.M1 milestone Dec 7, 2018
@rwinch
Copy link
Member

rwinch commented Dec 7, 2018

Thanks for the PR @weebl2000! This is now merged into master

@rwinch rwinch modified the milestones: 5.2.0.M1, 5.2.0.M2 Jan 16, 2019
@jgrandja jgrandja modified the milestones: 5.2.0.M2, 5.2.0.RC1 Apr 15, 2019
@rwinch rwinch merged commit 6f5fa1b into spring-projects:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AccountStatusUserDetailsChecker should implement MessageSourceAware
4 participants