Skip to content

Use SpringUtils to check scheme #6185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Conversation

bhavikkumar
Copy link
Contributor

Updated BasicAuthenticationFilter and ServerHttpBasicAuthenticationConverter to fix #6183

@pivotal-issuemaster
Copy link

@bhavikkumar Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster
Copy link

@bhavikkumar Thank you for signing the Contributor License Agreement!

@rwinch rwinch self-assigned this Nov 30, 2018
@rwinch rwinch added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Nov 30, 2018
@rwinch rwinch added this to the 5.2.0.M1 milestone Nov 30, 2018
@rwinch rwinch merged commit 90b9cfa into spring-projects:master Nov 30, 2018
@rwinch
Copy link
Member

rwinch commented Nov 30, 2018

Thanks for the PR @bhavikkumar! This is now merged into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BasicAuthenticationFilter could check the scheme more efficiently
3 participants