Make CachingUserDetailsService Public #6196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ir73 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@ir73 Thank you for signing the Contributor License Agreement! |
|
Thank you for the PR @ir73! Can you please update the commit message to align with the Spring Security conventions? |
ir73
force-pushed
the
caching-user-details
branch
2 times, most recently
from
50da2e1 to
19a7e91
Compare
|
sure, hope it looks better now. |
rwinch
changed the title
Made CachingUserDetailsService constructor public and moved to spring-core to make it easier to configure caching in UserDetailsService Fixes spring-projectsgh-4139
ir73
force-pushed
the
caching-user-details
branch
from
19a7e91 to
259f93a
Compare
|
@rwinch anything else I could help to get this PR merged? |
rwinch
added
in: core
|
@ir73 Thanks for the nudge. Somehow I had missed your comment from the other day. This is now merged into master. Thanks again for your contribution! It is great to see community members like you helping to make Spring better. I hope to see contributions from you again 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed based on the comments in this thread #4139