Skip to content

Improve error message for Chinese #6240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Improve error message for Chinese #6240

merged 1 commit into from
Dec 6, 2018

Conversation

wangzw
Copy link
Contributor

@wangzw wangzw commented Dec 6, 2018

Current error message translation of Chinese for "Bad credentials" is far away from perfect. Let's improve it.

Improve error message from "坏的凭证" (\u574f\u7684\u51ed\u8bc1) to "用户名或密码错误" (\u7528\u6237\u540d\u6216\u5bc6\u7801\u9519\u8bef)

@rwinch rwinch self-assigned this Dec 6, 2018
@rwinch rwinch added this to the 5.2.0.M1 milestone Dec 6, 2018
@rwinch rwinch added in: core An issue in spring-security-core type: enhancement A general enhancement labels Dec 6, 2018
@rwinch rwinch merged commit 12ab2cc into spring-projects:master Dec 6, 2018
@rwinch rwinch changed the title Improve error message for Chinese. Improve error message for Chinese Dec 6, 2018
@wangzw wangzw deleted the err_message branch March 13, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants