Skip to content

Add cookieDomain to CookieCsrfTokenRepository #6276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

dongmyo
Copy link
Contributor

@dongmyo dongmyo commented Dec 12, 2018

Add cookieDomain to CookieCsrfTokenRepository

Fixes: gh-4315

Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @dongmyo! See my comments for one quick change before we merge.

@jzheaux jzheaux merged commit 0d2af41 into spring-projects:master Dec 13, 2018
@jzheaux
Copy link
Contributor

jzheaux commented Dec 13, 2018

Thanks, @dongmyo! This is now merged into master.

@rwinch rwinch added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Dec 14, 2018
@rwinch rwinch added this to the 5.2.0.M1 milestone Dec 14, 2018
@rwinch rwinch added the status: duplicate A duplicate of another issue label Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to set the cookie domain in class CookieCsrfTokenRepository
3 participants