Skip to content

JdbcUserDetailsManager handles extra UserDetails attributes #6309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

pvliss
Copy link
Contributor

@pvliss pvliss commented Dec 19, 2018

Check ResutSetMetaData to see if extra columns are present in order to also handle the UserDetails attributes: accountNonExpired, accountNonLocked and credentialsNonExpired.

Fixes gh-4399

Check ResutSetMetaData to see if extra columns are present in order to
also handle the UserDetails attributes: accountNonExpired,
accountNonLocked and credentialsNonExpired.

Fixes spring-projectsgh-4399
@pvliss
Copy link
Contributor Author

pvliss commented Dec 21, 2018

Hello @rwinch.

API changes have now been removed.

@rwinch rwinch self-assigned this Dec 21, 2018
@rwinch rwinch added status: duplicate A duplicate of another issue in: core An issue in spring-security-core type: enhancement A general enhancement labels Dec 21, 2018
@rwinch rwinch added this to the 5.2.0.M1 milestone Dec 21, 2018
@rwinch rwinch merged commit 4123d96 into spring-projects:master Dec 21, 2018
@rwinch
Copy link
Member

rwinch commented Dec 21, 2018

@pvliss Thank you for all your work on this! I'm very pleased with how this turned out :) This is now merged into master.

We hope to see more contributions from you! If you are looking for something to contribute a good place to look is the Help Wanted issues which have been marked because they are typically a bit easier. If you want one of the issues, please comment on the issue to claim it so as not to duplicate efforts of others. Of course, if you find any issue you want to work on, don't hesitate to ping us via the comments. In any case, we are always happy to help you with a contribution. Thank you again for your contribution to the community!

@pvliss
Copy link
Contributor Author

pvliss commented Dec 21, 2018

@rwinch Thanks for all your guidance through my first PR!!!

Will certainly try to help as much as I can.

@pvliss pvliss deleted the gh-4399 branch July 19, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make JdbcUserDetailsManager to be able to handle UserDetails'es: nonLocked, nonExpired, credentialsNonExpired
2 participants