Skip to content

Added CompositeHeaderWriter #6455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Added CompositeHeaderWriter #6455

wants to merge 1 commit into from

Conversation

ankurpathak
Copy link
Contributor

@ankurpathak ankurpathak commented Jan 18, 2019 •
edited by jzheaux
Loading

  1. Added new CompositeHeaderWriter
  2. Improvement in DelegatingRequestMatcherHeaderWriter using
    CompositeHeaderWriter.
  3. Improvement in HeaderWriterFilter using CompositeHeaderWriter.

Fixes: gh-6453

@ankurpathak ankurpathak mentioned this pull request Jan 18, 2019
Closed
jzheaux
jzheaux requested changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for yet another PR, @ankurpathak! You totally rock!

I've left some feedback inline.

web/src/main/java/org/springframework/security/web/header/HeaderWriterFilter.java Outdated

HeaderWriterResponse(HttpServletRequest request, HttpServletResponse response,
List<HeaderWriter> headerWriters) {
CompositeHeaderWriter compositeHeaderWriter) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please do two indents for continuations? Even with method parameters, this is the formatting convention.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please do two indents for continuations? Even with method parameters, this is the formatting convention.

I did it. But please confirm it and if its not correct pls give example. I really face problem in understanding indentation.

@jzheaux jzheaux self-assigned this Jan 18, 2019
@ankurpathak ankurpathak force-pushed the gh-6453-fix branch 4 times, most recently from c6212ba to d7c52f5 Compare January 19, 2019 22:34
jzheaux
jzheaux requested changes Jan 20, 2019
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just remove DelegatingRequestMatcherHeaderWriter from the commit, and then we are good to go. Thanks, again, @ankurpathak!

...va/org/springframework/security/web/header/writers/DelegatingRequestMatcherHeaderWriter.java Outdated
@@ -1,5 +1,5 @@
/*
* Copyright 2002-2013 the original author or authors.
* Copyright 2002-2019 the original author or authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant to say was that we should remove this file from the commit. It will work nicely with CompositeHeaderWriter without modification.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File Removed.

@ankurpathak
Added CompositeHeaderWriter
39aa36b 
1. Added new CompositeHeaderWriter
2. Improvement in HeaderWriterFilter using CompositeHeaderWriter.

Fixes: 6453
@jzheaux
Copy link
Contributor

jzheaux commented Jan 21, 2019

@ankurpathak thanks again for the PR! This has now been merged into master via 718641a and a couple of polishes via bb1b9d9 and c82440e

@jzheaux jzheaux closed this Jan 21, 2019
@jzheaux jzheaux added status: duplicate A duplicate of another issue New Feature in: web An issue in web modules (web, webmvc) labels Apr 14, 2019
@jzheaux jzheaux added this to the 5.2.0.M2 milestone Apr 14, 2019
@rwinch rwinch added the type: enhancement A general enhancement label May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: web An issue in web modules (web, webmvc) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.M2
Development

Successfully merging this pull request may close these issues.

Add a composite HeaderWriter class
3 participants
@ankurpathak @jzheaux @rwinch