Set "rolePrefix" in ReactiveMethodSecurityConfiguration #6801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @ttddyy! Would you also be able to write some tests that confirm that this behavior works as expected? I think none have been added to this point, but you should be able to do something similar to And then, is there any reason that you chose to have the |
ttddyy
force-pushed
the
role-prefix-in-reactive
branch
from
a6771d7 to
f0105d6
Compare
|
Hi @jzheaux Updated the PR for
Thanks, |
ttddyy
force-pushed
the
role-prefix-in-reactive
branch
from
f0105d6 to
3d58d9b
Compare
rwinch
requested changes
Apr 30, 2019
| * @since 5.0 | ||
| */ | ||
| @Configuration | ||
| class ReactiveMethodSecurityConfiguration implements ImportAware { | ||
| private int advisorOrder; | ||
|
|
||
| @Autowired(required = false) | ||
| private GrantedAuthorityDefaults grantedAuthorityDefaults; |
Currently, `GrantedAuthorityDefaults` is not considered in `ReactiveMethodSecurityConfiguration`. This commit updates the configuration to be aware of `GrantedAuthorityDefaults` and update `rolePrefix` when the bean is available. Also, use the same instance of `DefaultMethodSecurityExpressionHandler` when constructing `ExpressionBasedAnnotationAttributeFactory`.
ttddyy
force-pushed
the
role-prefix-in-reactive
branch
from
3d58d9b to
d619434
Compare
rwinch
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
GrantedAuthorityDefaultsis not considered inReactiveMethodSecurityConfiguration.This commit updates the configuration to be aware of
GrantedAuthorityDefaultsand updaterolePrefixwhen the bean isavailable.
Also, use the same instance of
DefaultMethodSecurityExpressionHandlerwhen constructing
ExpressionBasedAnnotationAttributeFactory.